Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import version number from a .py file rather than reading a .txt file. #5

Merged
merged 2 commits into from Apr 13, 2012

Conversation

takluyver
Copy link
Contributor

The version.txt approach broke xlrd for people using freezer tools to bundle it into applications. This PR uses an info.py file to store the version number instead.

From discussion on the mailing list, although this needs a bit of a hack in setup.py, it should work for everyone.

@cjw296
Copy link
Member

cjw296 commented Apr 11, 2012

Have you tested this patch with the problematic freeze tools?
I'd rather not go round this particular circle again...

@takluyver
Copy link
Contributor Author

I'm pretty confident it should avoid the problem, but I'll test later today.

@cjw296
Copy link
Member

cjw296 commented Apr 11, 2012

Okay, please update with what you find.

@takluyver
Copy link
Contributor Author

I replicated the problem in master using cx_Freeze, and confirmed that it works properly using this branch.

@takluyver
Copy link
Contributor Author

And it needed to be in MANIFEST as well, for sdists to include it. Just fixed that.

@cjw296 cjw296 merged commit 12f2fb3 into python-excel:master Apr 13, 2012
@takluyver
Copy link
Contributor Author

On 14 April 2012 12:33, sjmachin
reply@reply.github.com
wrote:

The 0.7 branch MUST continue to support Python 2.1 and 2.2. However:

Is that requirement being dropped for the 0.8 series? When I started
using Python, it was version 2.5, so I don't really know what's going
to break in ancient versions.

Remedy: Use sys.argv[0] instead of file

Do you want me to make another pull request for this, or are you going
to take care of it?

@cjw296
Copy link
Member

cjw296 commented Apr 15, 2012

On 14/04/2012 13:03, Thomas Kluyver wrote:

On 14 April 2012 12:33, sjmachin
reply@reply.github.com
wrote:

The 0.7 branch MUST continue to support Python 2.1 and 2.2. However:

Is that requirement being dropped for the 0.8 series?

Yes.

Remedy: Use sys.argv[0] instead of file

Do you want me to make another pull request for this, or are you going
to take care of it?

I'll take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants